fix: silently renew expired access token on init instead of nulling userData - #1139
Open
abebehailu wants to merge 1 commit into
Open
fix: silently renew expired access token on init instead of nulling userData#1139abebehailu wants to merge 1 commit into
abebehailu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On initial render,
AuthProvidernow attempts a silent token renewal when itfinds a stored user whose access token has expired but user has a refresh token if autologin is disabled.
Why
In the init effect,
userManager.getUser()returns the stored user and theexpired branch is entered via
(!user || user.expired). Previously that branchonly had two outcomes for an expired user:
autoSignIn: true→ an immediate full-pagesigninRedirect, even though avalid refresh token was available and a silent renewal would have sufficed.
autoSignIn: false→ nothing happened, souserDatawas leftnulland theapp treated the user as logged out despite a renewable session.
Neither path used the refresh token, so a user with an expired access token but
a valid refresh token was unnecessarily bounced to the provider (or shown as
signed out).
Change
In the init effect, when there is an existing expired user and no auth code
in the URL and autologin is disabled, call
userManager.signinSilent().